Skip to content

refactor(WWSaveLoad): Qualify save-load and stub implementation includes#2878

Open
CryoTheRenegade wants to merge 1 commit into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/wwvegas-saveload-stubs
Open

refactor(WWSaveLoad): Qualify save-load and stub implementation includes#2878
CryoTheRenegade wants to merge 1 commit into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/wwvegas-saveload-stubs

Conversation

@CryoTheRenegade

Copy link
Copy Markdown

Qualifies cross-component header includes in WWSaveLoad and WWStub implementation files. Public headers and CMake include-directory behavior remain unchanged to preserve existing consumers.

@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown

Greptile Summary

This PR qualifies implementation-only cross-component includes in WWSaveLoad and WWStub.

  • Uses WWLib/ paths for shared library headers.
  • Uses WWDebug/ paths for debug and profiling headers.
  • Leaves public headers and CMake include-directory behavior unchanged.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
Core/Libraries/Source/WWVegas/WWSaveLoad/definition.cpp Qualifies the Chunk I/O include with WWLib/.
Core/Libraries/Source/WWVegas/WWSaveLoad/definitionfactorymgr.cpp Qualifies the debug include with WWDebug/.
Core/Libraries/Source/WWVegas/WWSaveLoad/definitionmgr.cpp Qualifies Chunk I/O, debug, memory-log, and profiling includes.
Core/Libraries/Source/WWVegas/WWSaveLoad/parameter.cpp Qualifies the string utility include with WWLib/.
Core/Libraries/Source/WWVegas/WWSaveLoad/pointerremap.cpp Qualifies the debug include with WWDebug/.
Core/Libraries/Source/WWVegas/WWSaveLoad/saveload.cpp Qualifies shared library and debug-related includes.
Core/Libraries/Source/WWVegas/WWSaveLoad/saveloadstatus.cpp Qualifies the mutex include with WWLib/.
Core/Libraries/Source/WWVegas/WWSaveLoad/twiddler.cpp Qualifies random, platform, timer, and debug helper includes.
Core/Libraries/Source/WWVegas/WWStub/wwallocstub.cpp Pins the allocator stub to the WWLib always.h header.
Core/Libraries/Source/WWVegas/WWStub/wwdebugstub.cpp Pins the debug stub to the WWDebug header.

Reviews (1): Last reviewed commit: "refactor(WWSaveLoad): Qualify save-load ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant